Skip to content

fix(gossipsub): readd lines accidently removed with jxs#12#13

Merged
jxs merged 1 commit intojxs:impl-gossipsub-backpressure-2from
elenaf9:gossipsub/backpressure/readd-logs
Nov 22, 2024
Merged

fix(gossipsub): readd lines accidently removed with jxs#12#13
jxs merged 1 commit intojxs:impl-gossipsub-backpressure-2from
elenaf9:gossipsub/backpressure/readd-logs

Conversation

@elenaf9
Copy link

@elenaf9 elenaf9 commented Nov 22, 2024

Description

#12 accidentally removed some trace logging lines and one line with actual logic.
Sorry about that, I only noticed now when reviewing libp2p#5595 again! This PR re-adds them.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Copy link
Owner

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jxs jxs merged commit 1789386 into jxs:impl-gossipsub-backpressure-2 Nov 22, 2024
@elenaf9 elenaf9 deleted the gossipsub/backpressure/readd-logs branch November 22, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants